-
-
Notifications
You must be signed in to change notification settings - Fork 261
feat: clear delivered iOS notifications when a channel or DM is read #2069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -83,6 +83,9 @@ struct UserMessageList: View { | |
| readMessageIDs.append(unreadTapback.messageId) | ||
| } | ||
| notificationManager.cancelNotificationsForMessageIds(readMessageIDs) | ||
| // Also clear any notifications for this conversation that were already delivered to | ||
| // Notification Center, so opening the DM wipes its piled-up notifications. | ||
| notificationManager.removeDeliveredNotifications(forDirectMessageUserNum: user.num) | ||
|
Comment on lines
+86
to
+88
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win Update Same as the channel-side change: clearing delivered notifications when a DM thread is opened is a user-visible behavior change under As per path instructions, 🤖 Prompt for AI AgentsSource: Path instructions |
||
| if context.hasChanges { | ||
| try context.save() | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Update
docs/user/messages.mdfor this user-visible behavior change.This change makes delivered notifications disappear from Notification Center when a channel is read — a user-visible behavior change in
Meshtastic/Views/Messages/.As per path instructions,
Meshtastic/Views/Messages/**/*.swift: "Updatedocs/user/messages.mdwhen code inMeshtastic/Views/Messages/changes in a user-visible way."🤖 Prompt for AI Agents
Source: Path instructions