Add LoRa coding rate preset override controls#1929
Open
RCGV1 wants to merge 2 commits into
Open
Conversation
Member
|
I don't really like this pattern, once you go to custom stuff you are customizing things. |
Member
Author
|
I disagree, modifying your coding rate isn't "custom" it doesn't make your packets get ignored by other nodes running different coding rates. I want to encourage people to use different coding rates, as depending on your deployment, you may need a higher coding rate to get out. @NomDeTom can back me up here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coding_rate = 0for preset-default CR instead of writing an explicit equal-to-default value.Reasoning
Firmware now allows
config.lora.coding_rateto override a preset only when the value is a valid higher/more redundant CR. Equal or lower values should fall back to the preset CR. The UI mirrors that rule by filtering preset-mode choices to0or strictly higher values, while custom mode still exposes explicit4/5...4/8values.Screenshot
Verification
git diff --checkpassed.xcodebuild -workspace Meshtastic.xcworkspace -scheme Meshtastic -configuration Debug -destination 'platform=iOS,id=00008130-000578880102001C' -derivedDataPath /tmp/meshtastic-device-derived -skipPackagePluginValidation -skipMacroValidation build