fix(configurator): add missing includeTest and includeBots to dependency arrays#91
Merged
derpyspike merged 1 commit intoJun 6, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When using the Configuration Generator and checking the "Test" or "Bots" checkboxes, the QR code and internal config were updated correctly. But if you clicked "Share configuration", the copied URL didn't reflect those two channels. The browser address bar had the same issue, it wouldn't update when toggling Test or Bots.
So if you shared that URL with someone, they'd get a different configuration than what you had on screen.
Fix
The useMemo that generates the shareable URL and the useEffect that syncs the browser address bar both had includeTest and includeBots missing from their dependency arrays. Just added them.