Refactor xc-grid functions#486
Open
YutingDuan111 wants to merge 27 commits into
Open
Conversation
Removed obsolete energy test entries for PSB3 and water.
Removed obsolete DFT energy test entries for PSB3.
vtripath65
reviewed
May 9, 2026
vtripath65
reviewed
May 9, 2026
vtripath65
reviewed
May 9, 2026
vtripath65
reviewed
May 9, 2026
vtripath65
reviewed
May 9, 2026
vtripath65
requested changes
May 9, 2026
vtripath65
left a comment
vtripath65
left a comment
Collaborator
There was a problem hiding this comment.
very small changes needed. Looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Implement SG-2, SG-3 standard grids and custom EML grids
Description
This PR introduces the SG-2 and SG-3 standard quadrature grids with pruning, based on the implementation described by Dasgupta and Herbert (J. Comput. Chem. 38, 869-882 (2017)). It also adds support for custom EML (Euler-Maclaurin + Lebedev) grids.
Key Changes
quick_gridpoints_module.f90:gridformLBDAngularfor custom EML grid configurations.quick_method_module.f90:useEML,eml_radial, andeml_angular.iSGvariable to support states2(SG-2) and3(SG-3).