Skip to content

Fixes Duplicate Key Warnings#9

Closed
awmichel wants to merge 1 commit into
mericson:masterfrom
permitzone:fix/duplicate-key-warnings
Closed

Fixes Duplicate Key Warnings#9
awmichel wants to merge 1 commit into
mericson:masterfrom
permitzone:fix/duplicate-key-warnings

Conversation

@awmichel

@awmichel awmichel commented Sep 2, 2015

Copy link
Copy Markdown

Fixes the following two warnings about duplicate hash keys:

/Users/***/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/people-0.2.1/lib/people.rb:276: warning: duplicated key at line 279 ignored: :parsed
/Users/***/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/people-0.2.1/lib/people.rb:277: warning: duplicated key at line 280 ignored: :parse_type

@awmichel

awmichel commented Sep 2, 2015

Copy link
Copy Markdown
Author

Didn't check existing PRs, looks like #5, #6, #7, and #9 are all related.

@djudd

djudd commented Oct 15, 2015

Copy link
Copy Markdown

I was about to make yet another, glad I checked first. Looks like this repository is dead, unfortunately. @mericson ?

@sshaw

sshaw commented Nov 18, 2015

Copy link
Copy Markdown

Yes, @mericson is active, just not giving this any love 😿 💔

@djudd's version looks legit. @djudd, what do ya say?

@sshaw

sshaw commented Nov 18, 2015

Copy link
Copy Markdown

Any of you folks used nameable?

@djudd

djudd commented Nov 18, 2015

Copy link
Copy Markdown

This fork has some fixes and performance improvements, and we're using pretty heavily it in production at Academia.edu: https://github.com/academia-edu/people

I was not previously aware of https://github.com/chorn/nameable but it looks like it could be helpful. The parsing implementation seems to be similar to the People gem, a bit easier to read, but with no explicit handling of initials.

There's also https://github.com/berkmancenter/namae, which uses a grammar instead of ad-hoc heuristics - misses some cases as a result but also covers some new ones.

I'm working on a Rust library https://github.com/djudd/human-name - as a side project to learn Rust, but with the intent of possibly using it in production eventually. It's currently at an alpha stage, but ~30x faster than the Ruby gems I've tested, and adds intelligent equality testing. I do intend to write Ruby bindings at some point, but that's probably at least a few weeks away.

@awmichel awmichel closed this May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants