Added test with RSpec#1
Open
perryjg wants to merge 3 commits into
Open
Conversation
…ation matching and case options
…ordinal suffix test
tilo
referenced
this pull request
in 1debit/people
Aug 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Matt,
I've been trying to learn more about testing and, more specifically, about RSpec. So when I saw your message on NICAR-L about your people gem, I thought that adding some tests would be a good little project. It's not comprehensive, but it's a start.
There is one test that fails -- the regex for parse type 11, "MATTHEW E. SHEIE ERICSON," doesn't sem to work. But maybe I did something wrong.
Also, the title regex was capturing a trailing space. Don't know if that's what you intended, but I went ahead and made the test comply with the current behavior.
Anyway, here;'s some tests you can use or not, whatever you feel like doing.
-- john