perf: add database indexes on frequently queried columns - #79
Merged
Conversation
|
@Fayyo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add database indexes on frequently queried columns to improve query performance as the dataset grows. Indexes target the most common query patterns identified in route handlers: listing expenses by group (sorted by date), fetching settlements ordered by date, and retrieving audit logs by entity.
Changes
New indexes added to
prisma/schema.prisma@@index([groupId, createdAt])group_id, created_atfindMany({ where: { groupId }, orderBy: { createdAt: "desc" } })used in expense listing, ledger, and balance computation@@index([createdAt])created_atGET /history) and worker FIFO processing@@index([entityType, entityId])entity_type, entity_id@@index([createdAt])created_atExisting indexes that already covered other AC requirements
GroupMember:@@index([userId])and@@unique([groupId, userId])(composite B-tree coversgroupId, userIdlookups) ✅Expense:@@index([groupId]),@@index([payerUserId])✅Settlement:@@index([groupId]),@@index([status]),@@index([fromUserId]),@@index([toUserId])✅AuditLog:@@index([userId])✅Migration
Generated migration at
prisma/migrations/20260728000001_add_query_indexes/migration.sql:CREATE INDEX "expenses_group_id_created_at_idx" ON "expenses"("group_id", "created_at");CREATE INDEX "settlements_created_at_idx" ON "settlements"("created_at");CREATE INDEX "audit_logs_entity_type_entity_id_idx" ON "audit_logs"("entity_type", "entity_id");CREATE INDEX "audit_logs_created_at_idx" ON "audit_logs"("created_at");Note on over-indexing
Expense does not have a
statusfield (status exists onExpenseShare, notExpenseitself), so the suggested@@index([status])was omitted to avoid referencing a non-existent column.Testing
\diCloses #35