Skip to content
This repository was archived by the owner on May 10, 2021. It is now read-only.

Add preview#3

Open
acellam wants to merge 5 commits into
mendix:masterfrom
FlockOfBirds:feature/preview
Open

Add preview#3
acellam wants to merge 5 commits into
mendix:masterfrom
FlockOfBirds:feature/preview

Conversation

@acellam
Copy link
Copy Markdown

@acellam acellam commented May 24, 2017

-web modeler preview

@acellam acellam force-pushed the feature/preview branch from acebb27 to dfb73ce Compare June 2, 2017 13:52
Comment thread webpack.config.js Outdated
],
plugins: [
new CopyWebpackPlugin([
{ from: "src/**/*.js" },
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont need to copy .js files, they com from webpack

Comment thread webpack.config.js Outdated
libraryTarget: "commonjs"
},
resolve: {
extensions: [ ".ts", ".js" ]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you live without ".js" ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, can live without it

Comment thread webpack.config.js
const widgetConfig = {
entry: "./src/PullToRefresh/widget/PullToRefresh.ts",
output: {
path: path.resolve(__dirname, "dist/tmp"),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Target libraryTarget: "umd" should be amd else the minifycation will break the client.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Thanks i was unware. corrected

Comment thread webpack.config.js
const widgetConfig = {
entry: "./src/PullToRefresh/widget/PullToRefresh.ts",
output: {
path: path.resolve(__dirname, "dist/tmp"),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in webpack 2 you don't need to resolve the extension ".json"
and probably also no js

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing the knowledge , i have made the correction

Comment thread webpack.config.js Outdated
"dojo/dom-style" ],
"react",
"react-dom",
"mxui/widget/_WidgetBase",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mx and dojo externals could be added with regex

externals: [ "react", "react-dom", /^mxui\/|^mendix\/|^dojo\/|^dijit\// ],

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one! ;)

Comment thread README.md Outdated

## Dependencies
Mendix version 6.10 or up
Mendix version 7.3 or up
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Widget should stay compatible with 6.10
Though the preview will only for the web modeler

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure it does, reverted back

@acellam acellam force-pushed the feature/preview branch from b3c4e48 to c5402af Compare June 8, 2017 08:46
@acellam acellam force-pushed the feature/preview branch from c5402af to 8be4261 Compare June 8, 2017 08:48
@diego-antonelli
Copy link
Copy Markdown
Contributor

Please update the files to avoid conflicts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants