feat: sync metrics with memgraph counters/gauges/histograms#33
Merged
Conversation
imilinovic
force-pushed
the
fix/missing-metrics
branch
from
6c9be3f to
990637d
Compare
imilinovic
changed the title
11 tasks
as51340
requested changes
May 21, 2026
Collaborator
as51340
left a comment
as51340
left a comment
There was a problem hiding this comment.
LGTM, before merging please start it with a standalone and HA and test nothing is broken
Align the exporter with the current memgraph event definitions: add
missing index, operator, transaction, constraint, schema/storage info
and memory metrics; refresh HA RPC timers and counters; drop entries
that no longer exist in memgraph. Use mg_data.get(key, {}) so missing
top-level groups from older memgraph versions don't abort the scrape.
imilinovic
force-pushed
the
fix/missing-metrics
branch
from
990637d to
6c3f456
Compare
ReplicaRecovery{Success,Fail,Skip} counters were constructed without
labels but updated through the labelled update_gauges helper, which
raised on every data-instance scrape and prevented the counters from
ever being published. Add the instance_name label and a matching
update_counters helper that uses .inc() so the dashboards' *_total
series populate correctly.
as51340
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the exporter with the current memgraph event definitions: add missing index, operator, transaction, constraint, schema/storage info and memory metrics; refresh HA RPC timers and counters; drop entries that no longer exist in memgraph.
Documentation checklist