merge duplicate listings across indexes, unify key hints and toasts - #11
Merged
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bodies of work that were in flight together on this branch.
Cross-index merge (new)
The same torrent listed on three indexes was three rows, each magnet carrying a different partial tracker set. Now it is one row, and the magnet queued announces to the union of every tracker those listings knew about — finding peers no single listing would have led to.
internal/provider/merge.go—Result.InfoHash()(hex, base32, uppercase),Merge,MergeAll,Result.Trackers(). Trackers union; seeders/leechers take the higher scrape;TrustedORs; size fills from whichever index knew it;AlsoOnrecords the others.MergeAllpicks its keeper by a total order independent of arrival, so a concurrent fan-out is reproducible. The tracker union is sorted for the same reason.UI: rows show
yts+2, the status line counts folded listings, and the graph detail panel reports the tracker total.UI/UX pass
Single keymap table feeding both the footer strip and the
?card so they cannot drift, unified toast system, and preview/downloads refinements.Notes
^djumps there from anywhere instead, including mid-typing (it is a chord so it needs none of the guards a letter does). Costs emacs delete-forward in text fields; thedeletekey still works.go vet, and-racegreen. New tests cover the merge primitive, streaming ingest, determinism under shuffled input, and the keybind across every screen.