Update dependencies#687
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR replaces ESLint/Prettier tooling with oxlint/oxfmt, updates Meilisearch import and Cypress task-wait patterns, adds an API key end-to-end test, and makes minor documentation and markup edits. ChangesLint and format tooling migration
Meilisearch client and Cypress flow updates
Documentation and markup edits
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant CypressTest
participant DashboardUI
participant ApiKeyModal
participant MeilisearchClient
CypressTest->>DashboardUI: visit("/")
DashboardUI->>ApiKeyModal: show API key prompt
CypressTest->>ApiKeyModal: enter wrong API key
ApiKeyModal->>MeilisearchClient: updateClient(wrong key)
MeilisearchClient-->>ApiKeyModal: error
ApiKeyModal-->>CypressTest: show invalid key message
CypressTest->>ApiKeyModal: enter valid API key
ApiKeyModal->>MeilisearchClient: updateClient(valid key)
MeilisearchClient-->>ApiKeyModal: success
ApiKeyModal-->>DashboardUI: close modal
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
@Strift should I review since it's in draft? |
Strift
force-pushed
the
chore/bump-dependencies
branch
from
June 30, 2026 06:28
8144648 to
d7dce62
Compare
Strift
marked this pull request as ready for review
July 1, 2026 04:27
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/tests.yml (1)
11-26: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winMissing explicit
permissionsblock onlinter_checkjob.Static analysis flags the job for relying on default (overly broad)
GITHUB_TOKENpermissions. Since this job only checks out code and runs lint/format, it doesn't need write access.🔒 Suggested fix
linter_check: runs-on: ubuntu-latest name: linter-check + permissions: + contents: read steps:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/tests.yml around lines 11 - 26, Add an explicit permissions block to the linter_check job in the tests workflow so it does not inherit broad default GITHUB_TOKEN access. Since this job only uses actions/checkout and runs yarn lint and yarn format:check, set the job-level permissions to read-only for repository contents using the linter_check job definition.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.vscode/settings.json:
- Around line 2-7: The VS Code settings are inconsistent because oxfmt is
disabled while editor.defaultFormatter and editor.formatOnSave still rely on
oxc.oxc-vscode. Update the settings in this block so formatting on save works
again by either re-enabling oxc.enable.oxfmt or switching the default formatter
away from oxc.oxc-vscode, and keep the formatter-related keys aligned.
In `@cypress/support/commands.js`:
- Around line 12-15: The deleteAllIndexes flow is still not awaiting the async
deletions because indexes.forEach ignores the promises from
client.deleteIndex(index.uid).waitTask(). Update the logic in deleteAllIndexes
to collect the per-index delete promises with map and await them with
Promise.all so the function only resolves after all index deletions complete.
---
Nitpick comments:
In @.github/workflows/tests.yml:
- Around line 11-26: Add an explicit permissions block to the linter_check job
in the tests workflow so it does not inherit broad default GITHUB_TOKEN access.
Since this job only uses actions/checkout and runs yarn lint and yarn
format:check, set the job-level permissions to read-only for repository contents
using the linter_check job definition.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3775516c-c2e8-465d-8f35-57dd2a2bae9a
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (26)
.eslintignore.eslintrc.json.github/workflows/tests.yml.oxfmtrc.json.oxlintrc.json.prettierrc.vscode/extensions.json.vscode/settings.json.yarnrc.ymlCONTRIBUTING.mdREADME.mdcypress.config.jscypress/e2e/test-api-key-query-param.cy.jscypress/e2e/test-api-key-required.cy.jscypress/support/commands.jsindex.htmlpackage.jsonsrc/App.jsxsrc/components/ApiKeyModalContent.jsxsrc/components/Header/index.jsxsrc/components/Results/Hit.jsxsrc/components/Results/index.jsxsrc/context/MeilisearchClientContext.jsxsrc/hooks/useLocalStorage.jssrc/utils/hasAnApiKeySet.jsvalidate-env.js
💤 Files with no reviewable changes (6)
- .prettierrc
- .eslintrc.json
- cypress/e2e/test-api-key-query-param.cy.js
- .eslintignore
- cypress.config.js
- cypress/e2e/test-api-key-required.cy.js
Contributor
Author
|
@curquiza we're now ready for a review 🙏 |
curquiza
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
meilisearchtov0.57.0@meilisearch/instant-meilisearchtov0.31.2(latest compatible withmeilisearch@^0.57)Dev dependencies updates to align with JS SDK tooling:
eslinttooxlint(internal)prettiertooxfmt(internal)PR checklist
Please check if your PR fulfills the following requirements:
Used Cursor AI assistance for rebase conflict resolution, dependency version checks, and running verification commands.
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit
Bug Fixes
Chores
Tests