Skip to content

Remove dependency on the deprecated cstr crate#362

Merged
Kerollmops merged 1 commit into
meilisearch:mainfrom
millert:remove-cstr
Apr 22, 2026
Merged

Remove dependency on the deprecated cstr crate#362
Kerollmops merged 1 commit into
meilisearch:mainfrom
millert:remove-cstr

Conversation

@millert

@millert millert commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

In Rust 1.77.0 and above, c"abc" can be used in place of cstr!("abc").

Kerollmops
Kerollmops previously approved these changes Apr 13, 2026

@Kerollmops Kerollmops left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho! I learned something today! Thank you. Great PR! Merging.

EDIT: after you do a small cargo fmt 😅

@Kerollmops Kerollmops enabled auto-merge April 13, 2026 21:36
In Rust 1.77.0 and above, c"abc" can be used in place of cstr!("abc").
auto-merge was automatically disabled April 13, 2026 21:41

Head branch was pushed to by a user without write access

@millert millert requested a review from Kerollmops April 21, 2026 14:56

@Kerollmops Kerollmops left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Merging. Have a nice day 🌵

@Kerollmops Kerollmops added this pull request to the merge queue Apr 22, 2026
Merged via the queue into meilisearch:main with commit f3b46b2 Apr 22, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants