fix: add missing decoupleprocessor module requires/replaces - #5
Merged
Conversation
default.go imports decoupleprocessor (and transitively lambdalifecycle) from the opentelemetry-lambda submodule, but go.mod never declared them. Both are unpublished local modules, so go test fails to resolve the import. Add local filesystem replace directives pointing into the submodule. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the adot/collector/lambdacomponents Go module dependency metadata so imports from the opentelemetry-lambda submodule (notably decoupleprocessor, plus transitive lambdalifecycle) can be resolved without Go attempting to auto-edit go.mod during go test.
Changes:
- Add
requireentries fordecoupleprocessorandlambdalifecycle, and add localreplacedirectives pointing into theopentelemetry-lambdasubmodule. - Add
processorhelperto module requirements and updatego.sumaccordingly.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| adot/collector/lambdacomponents/go.mod | Adds missing module requirements and local filesystem replace directives for opentelemetry-lambda components. |
| adot/collector/lambdacomponents/go.sum | Records new sums for processorhelper after dependency graph changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+20
to
24
| require go.opentelemetry.io/collector/processor/processorhelper v0.138.0 // indirect | ||
|
|
||
| require ( | ||
| cloud.google.com/go/auth v0.18.2 // indirect | ||
| cloud.google.com/go/auth/oauth2adapt v0.2.8 // indirect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default.go imports decoupleprocessor (and transitively lambdalifecycle) from the opentelemetry-lambda submodule, but go.mod never declared them. Both are unpublished local modules, so go test fails to resolve the import. Add local filesystem replace directives pointing into the submodule.
Description: <Describe what has changed.
Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.>
Link to tracking Issue:
Testing: < Describe what testing was performed and which tests were added.>
Documentation: < Describe the documentation added.>
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.