Add searching as a tool instead of as resource - #2
Open
meghanmurphy1 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resources with parameter binding are resource templates not necessarily resources and it's a known issue that they're not being shown on Claude Ui modelcontextprotocol/python-sdk#92 😞
I'm thinking for at least demo purposes to have the searching be tools even though in this instance its getting data and resources are supposed to be used as GET endpoints and tools are more for transformations. I may also be missing something about the difference between the 2.
I've also seen where devs who have built out full MCP servers have just used tools for everything so I don't know if there's really a set precedent here anyways?
It also seems easier to use a tool I've found using plain language like "search my index for documents about x" which I think you can do with resources but you would need to upload the integration json first