Migrate CI to pnpm v11: pin versions, frozen lockfile, build-script allowlist#96
Merged
Merged
Conversation
…llowlist Agent-Logs-Url: https://github.com/mdlew/ip/sessions/19c5feb0-c53e-40fe-bdaa-650e72ee12d4 Co-authored-by: mdlew <47911000+mdlew@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
mdlew
April 14, 2026 02:10
View session
There was a problem hiding this comment.
Pull request overview
Updates CI and pnpm configuration to support pnpm v11’s stricter lifecycle-script behavior and to move toward more deterministic installs.
Changes:
- Added
pnpm.onlyBuiltDependenciesinpackage.jsonto allow postinstall scripts foresbuild,sharp, andworkerd. - Refactored the deploy workflow to use explicit Node + pnpm setup steps and a standalone dependency install command.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| package.json | Adds pnpm build-script allowlist (but still uses latest dependency versions). |
| .github/workflows/deploy.yml | Switches to separate Node/pnpm setup + install step (but currently not pinned/deterministic as described). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm v11 blocks all dependency lifecycle scripts by default, breaking installs for packages that download platform-specific native binaries. The existing workflow also mutated the lockfile on every run via
--force --fix-lockfile --no-frozen-lockfile, making builds non-deterministic.package.json— build-script allowlistAdded
pnpm.onlyBuiltDependenciesto explicitly permit postinstall scripts for the three packages that need them:deploy.yml— deterministic, pinned CIactions/setup-node@v4typescriptinstall (typescriptis already indevDependencies)