Skip to content

Fix for MSTP packet display issue#55

Open
ACodingfreak wants to merge 1 commit into
mcr:masterfrom
ACodingfreak:master
Open

Fix for MSTP packet display issue#55
ACodingfreak wants to merge 1 commit into
mcr:masterfrom
ACodingfreak:master

Conversation

@ACodingfreak
Copy link
Copy Markdown
Contributor

Fix for output formatting
fix for issue with MSTP packets

@mcr
Copy link
Copy Markdown
Owner

mcr commented Mar 10, 2013

Can you provide a test case for these changes (a pcap file).
I guess that there was not any MSTP examples in tests/ before, so this would be very much appreciated.

@ACodingfreak
Copy link
Copy Markdown
Contributor Author

I will add an MSTP pcap file and update the same in test case and will drop
a pull request

Regards,

Ajith

codingfreak.blogspot.com http://www.codingfreak.blogspot.com

On Sun, Mar 10, 2013 at 11:11 PM, Michael Richardson <
notifications@github.com> wrote:

Can you provide a test case for these changes (a pcap file).
I guess that there was not any MSTP examples in tests/ before, so this
would be very much appreciated.


Reply to this email directly or view it on GitHubhttps://github.com//pull/55#issuecomment-14685283
.

@infrastation
Copy link
Copy Markdown
Contributor

@ajithadapa, any new commits you add to this branch count in the original pull request, even if you rebase the branch.

@mcr
Copy link
Copy Markdown
Owner

mcr commented Mar 28, 2013

Can you rebase this and add the pcap file? Thanks.

@ACodingfreak
Copy link
Copy Markdown
Contributor Author

Sorry but I am a bit confused as I am new to git.

Should I pull "upstream" changes using commands git fetch upstream and then
git merge upstream/master and then update my fork tree with the MSTP pcap file ?

or

Just add the MSTP pcap file to my current fork tree and do a pull request ?

@infrastation
Copy link
Copy Markdown
Contributor

git fetch upstream
git rebase upstream/master

@mcr mcr closed this Apr 14, 2013
@mcr
Copy link
Copy Markdown
Owner

mcr commented Apr 14, 2013

Merged manually.

@mcr mcr reopened this Apr 14, 2013
@mcr
Copy link
Copy Markdown
Owner

mcr commented Apr 14, 2013

Well, actually, I didn't get it to compile properly, so I removed the code.
What is the length variable at line 338?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants