[codex] Stabilize incremental rebuild caching#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gcm/.ooutputs are no longer overwritten or touched.Toolchain::driverIdent) and use it for fingerprint field 3 instead of hashing the compiler binary contents when available.--versionoutput so equivalent xlings toolchains installed under different prefixes share a fingerprint..agents/docs/2026-05-15-fingerprint-stability-and-fastpath-coherence.mdwith the PR comparison and follow-up design notes.Root Cause
There were two related incremental rebuild problems:
hash_file(tc.binaryPath). Equivalent xlings GCC packages installed under different registry prefixes can have different binary bytes, so switching between local/dev mcpp and installed mcpp could silently select a newtarget/<triple>/<fingerprint>directory and look like a full rebuild.Validation
target/x86_64-linux-gnu/b2f2305667355830/bin/test_bmi_cachetarget/x86_64-linux-gnu/b2f2305667355830/bin/test_toolchain_detecttarget/x86_64-linux-gnu/b2f2305667355830/bin/test_fingerprintgit diff --check -- <changed files>mcpp build --verboseno-change path in the new fingerprint dir:ninja: no work to dotouch src/main.cpp && mcpp build --verbose: 4 Ninja edges,0.36slocallyScope Notes
This PR intentionally does not change
.build_cacheformat orcxx_scanrestat behavior. Those are documented as follow-up P1/P2 items in the analysis doc so the 0.0.15 fix stays focused.