Skip to content

chore: remove dependabot groups#3145

Merged
rwaskiewicz merged 2 commits into
mainfrom
rw/rm-dependabot-grouping
Jun 25, 2026
Merged

chore: remove dependabot groups#3145
rwaskiewicz merged 2 commits into
mainfrom
rw/rm-dependabot-grouping

Conversation

@rwaskiewicz

@rwaskiewicz rwaskiewicz commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Asana task: N/A
Description

Remove package-specific dependency groupings from the Dependabot configuration. Prior to this commit, we were seeing cases where NPM major version updates were falling into the npm-minor group. This caused related packages that were peer-dependent on one another's new major version to be split into separate PRs, causing each created PR to fail. The outcome following this PR is the same,
but will require manual intervention from the dev team to fix cases of broken major version updates.

One approach in #3142 was to move npm-minor to the bottom of the group list, and explicitly exclude each package in any group from npm-minor. This was tested to fix the above issue in a separate repo, but adds maintenance burden. As a result, we choose to simply remove the groups as they exist today

  • Tests added?

Remove package dependency groupings from the Dependabot configuration.
Prior to this commit, we were seeing cases where NPM major version
updates were falling into the `npm-minor` group. This caused related
packages that were peer-dependent on one another's new major version to
be split into separate PRs, causing each created PR to fail.

One approach in #3142 was to move
`npm-minor` to the bottom of the group list, and explicitly exclude each
package in any group from `npm-minor`. This was tested to fix the above
issue in a separate repo, but adds maintenance burden. As a result, we
choose to simply remove the groups as they exist today

The `mix-minor` group has been removed to keep with the same behavior as
not having `npm-minor`.
@rwaskiewicz rwaskiewicz marked this pull request as ready for review June 25, 2026 18:31
@rwaskiewicz rwaskiewicz requested a review from a team as a code owner June 25, 2026 18:31
@digitalcora

Copy link
Copy Markdown
Contributor

To clarify my previous comment, I meant that we could remove all groups other than the mix-minor and npm-minor, which I think are fairly essential to avoid a flood of individual PRs for tiny updates. I assumed the problem here was being caused by both the "minor" groups and the "named" groups existing together, rather than by any groups existing at all. I think this is supported by our experience using just "minor" groups on other repos, but I don't know if you've seen a counter-example.

@rwaskiewicz

rwaskiewicz commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Ah, okay - I see what you're saying. Fixed in 6985503 (and PR desc updated)

@digitalcora digitalcora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP, my beautiful groups...

@rwaskiewicz

Copy link
Copy Markdown
Contributor Author

Dependabot wasn't worthy. Renovatebot on the other hand, maybe some day 🌤️

@rwaskiewicz rwaskiewicz merged commit 38b0e51 into main Jun 25, 2026
20 checks passed
@rwaskiewicz rwaskiewicz deleted the rw/rm-dependabot-grouping branch June 25, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants