feat(flashback): Use current time for new/updated event timestamps#771
Merged
Conversation
LCOV of commit
|
LCOV of commit
|
LCOV of commit
|
huangh
reviewed
Jul 2, 2026
huangh
requested changes
Jul 2, 2026
huangh
left a comment
huangh
left a comment
Collaborator
There was a problem hiding this comment.
i think there's some weird timestamp logic now.
also, we have all these times in america/new_york..do we also have the epoch time representation? at a glance, it's easier to work with the epoch time without a library, but providing only datetimes would require more tooling to make it work.
basically is there a need for both the human readable and the machine computable versions to both be here?
and should the timestamp have _est notation? is it typical for times out of our api to be in eastern?
LCOV of commit
|
huangh
force-pushed
the
feature-flashback-publication-timestamp
branch
from
ff42538 to
e5a2e13
Compare
LCOV of commit
|
huangh
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana Task: 📸 update
timestampto reflect publishing timeWhat changes does this PR propose?
Generates the publication timestamp from the event loop rather than deriving it from the events. This lets us compare when flashback evaluated the event to when the event happened and infer from the difference how long it takes events to reach us.
How were these changes validated?
What questions should reviewers consider?
None.