fix: correct reduce logic to properly determine lowest grade#13
Open
mateuszzawisza wants to merge 1 commit into
Open
fix: correct reduce logic to properly determine lowest grade#13mateuszzawisza wants to merge 1 commit into
mateuszzawisza wants to merge 1 commit into
Conversation
Previously, the reduce callback returned a boolean instead of an accumulator, causing `lowestGrade` to hold an incorrect value. Updated the function to return the grade object with the lowest value instead of a boolean.
mateuszzawisza
force-pushed
the
grade-fix
branch
from
40bc8cd to
4a20df9
Compare
mateuszzawisza
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you for your excellent work on the action. It has become very useful for me.
I've found a small bug in the grade parsing code that prevented action from finding the lowest grade correctly and in effect not failing workload when grade was under defined threshold. Proposed change fixes it for me.
Description
Previously, the reduce callback returned a boolean instead of an accumulator, causing
lowestGradeto hold an incorrect value. Function was updated to return the grade object with the lowest value instead of a boolean.