Conversation
…authenticated while loading
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the user experience by adding consistent loading indicators throughout the community and post pages, as well as the navigation bar. It also enhances the community members modal and improves loading state handling for community membership actions. The changes ensure that users receive clear feedback when data is being fetched or actions are in progress, leading to a more polished and responsive interface.
Loading State Improvements
loadingstate to theuseCommunityPermissionshook and propagated it to all pages that use this hook, displaying aPostLoadercomponent or spinner while permissions or user data are loading (useCommunityPermissions.tsx,CommunityClientPage.tsx,PostClientPage.tsx,SubmitPostClientPage.tsx,RightContent.tsx). [1] [2] [3] app/community/[communityId]/comments/CommunityClientPage.tsxL45-R55, app/community/[communityId]/comments/[pid]/PostClientPage.tsxL45-R45, app/community/[communityId]/comments/[pid]/PostClientPage.tsxR65-R73, app/community/[communityId]/submit/SubmitPostClientPage.tsxR17, app/community/[communityId]/submit/SubmitPostClientPage.tsxL42-R52, [4] [5]RightContentcomponent) to show a spinner while authentication state is loading, preventing flicker and improving perceived performance (Navbar.tsx,RightContent.tsx). [1] [2] Ff7da671L4R4, [3]Community Membership Actions
CommunityHeader.tsx,JoinOrLeaveButton.tsx). [1] [2] [3] [4] [5]Community Members Modal Enhancements
CommunityMembersModal.tsx). [1] [2]Loader Component Integration
PostLoadercomponent across relevant pages to provide a consistent loading experience when posts or permissions are being fetched (CommunityClientPage.tsx,PostClientPage.tsx,SubmitPostClientPage.tsx). (app/community/[communityId]/comments/CommunityClientPage.tsxR11, app/community/[communityId]/submit/SubmitPostClientPage.tsxR17)These updates collectively make the application more user-friendly by clearly communicating loading states and improving the overall interface responsiveness.