Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the codebase to centralize and standardize type definitions by moving interface and type declarations from their respective atom files into a dedicated
@/typesdirectory. All relevant imports across the application have been updated to use these new type definitions, resulting in a cleaner and more maintainable codebase.Type and Interface Refactoring:
Community,CommunitySnippet, and related types fromatoms/communitiesAtom.tsto@/types/community, updating all imports accordingly throughout the codebase. [1] [2] app/community/[communityId]/CommunityClientPage.tsxL3-R11, app/community/[communityId]/comments/[pid]/PostClientPage.tsxL4-R4, app/community/[communityId]/comments/[pid]/PostClientPage.tsxR21-R22, app/community/[communityId]/submit/SubmitPostClientPage.tsxL4-R4, app/community/[communityId]/submit/SubmitPostClientPage.tsxR14, [3] [4] [5] [6] [7] [8] [9] [10]Post,PostVote, and related types fromatoms/postsAtom.tsto@/types/post, and updated all usages. [1] app/community/[communityId]/comments/[pid]/PostClientPage.tsxL4-R4, app/community/[communityId]/comments/[pid]/PostClientPage.tsxR21-R22, [2]SavedPosttype fromatoms/savedPostsAtom.tsto@/types/savedPostand updated imports.AuthModalStatefromatoms/authModalAtom.tsto@/types/authModaland updated all references.DirectoryMenuItemfromatoms/directoryMenuAtom.tsto@/types/directoryMenuand updated all relevant imports.Cleanup and Consistency:
@/typesdirectory. [1] [2] [3] [4] [5]This refactor improves maintainability, makes type management more scalable, and reduces the risk of type inconsistencies across the project.