Remove Ensure.That NuGet dependency - #18
Conversation
|
@copilot remove initial plan commit to clean up git history. And run ci build action on this pr |
I squashed the two commits locally but the push was rejected because my environment doesn't support force-pushing. You can clean up the history yourself with: git fetch origin copilot/remove-dependencies
git checkout copilot/remove-dependencies
git reset --soft HEAD~1
git commit --amend -m "Remove Ensure.That dependency from Mbc.Ads.Mapper"
git push --force-with-lease origin copilot/remove-dependenciesRegarding the CI build — the workflow was already triggered automatically by the PR push, but both runs show |
|
@copilot ci build failed. Build the .net Solution and fix build failers |
The CI failure was caused by |
|
@copilot ci build still fails. Fix it |
Fixed in commit |
Removes the third-party
Ensure.Thatpackage fromMbc.Ads.Mapper, replacing its guard calls with equivalent inline standard .NET exception throws.Changes
Mbc.Ads.Mapper.csproj— removed<PackageReference Include="Ensure.That" Version="10.1.0" />MemberMappingConfiguration.cs— replacedEnsureArg.IsNotNullwithArgumentNullExceptionAdsBinaryAccessorFactory.cs— replacedEnsure.Any.IsNotNull/EnsureArg.IsGtewithArgumentNullException/ArgumentOutOfRangeExceptionAll checks remain compatible with the
netstandard2.0target framework.