Revert "fix: make OG/Twitter meta tags use dynamic origin for local dev (#179)"#305
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mayo-byte07
added
type:bug
There was a problem hiding this comment.
Pull request overview
Reverts prior changes related to Open Graph/Twitter metadata behavior (per PR title/description) and cleans up merge-conflict artifacts, restoring expected routes/meta handling in the Conn server + static frontend.
Changes:
- Removes leftover merge-conflict artifacts and standardizes the click rate-limit message in
server.js. - Reverts click-tracking route wiring and related client-side click POST behavior alignment.
- Adjusts
index.htmlTwitter meta tags and associated inline meta-tag rewrite logic; resolves a custom CSS sanitizer merge conflict inapp.js.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| server.js | Cleans up conflict artifacts; modifies click-tracking middleware/route behavior. |
| public/js/app.js | Resolves a merge-conflict in the custom CSS sanitization chain. |
| public/index.html | Updates Twitter meta tags and removes twitter:url handling; keeps other meta-tag logic in place. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1254
to
1258
| // Track clicks (public — find link by ID across all users) | ||
| <<<<<<< fix/179-dynamic-og-domain | ||
| app.post('/api/links/:id/click', clickLimiter, async (req, res) => { | ||
| ======= | ||
| app.post('/api/links/:id/click', requireAuth, clickLimiter, async (req, res) => { | ||
| >>>>>>> main | ||
| const { data: link } = await supabase | ||
| .from('user_links') | ||
| .select('id, clicks') |
Comment on lines
39
to
43
| <script> | ||
| (function() { | ||
| var origin = window.location.origin; | ||
| var canonical = document.getElementById('canonicalTag'); | ||
| var ogUrl = document.getElementById('ogUrl'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #293