Skip to content

feat(a11y): add global focus-visible and aria-labels (#126) #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhi666-max wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(a11y): add global focus-visible and aria-labels (#126) #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7be9ed
feat(a11y): add global focus-visible and aria-labels (#126)
Abhi666-max Jun 17, 2026
161e5dc
feat(a11y): add focus indicator and ensure aria-labels
Abhi666-max Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions public/admin.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,12 @@
<span class="sidebar-url-label">Your public link</span>
<div class="sidebar-url-row">
<span class="sidebar-url-text" id="publicUrlText">conn.app/u/...</span>
<button class="sidebar-url-copy" id="copyPublicUrl" title="Copy link">
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><rect x="9" y="9" width="13" height="13" rx="2" ry="2"/><path d="M5 15H4a2 2 0 0 1-2-2V4a2 2 0 0 1 2-2h9a2 2 0 0 1 2 2v1"/></svg>
<button class="sidebar-url-copy" id="copyPublicUrl" title="Copy link" aria-label="Copy public link">
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round"
stroke-linejoin="round">
<rect x="9" y="9" width="13" height="13" rx="2" ry="2" />
<path d="M5 15H4a2 2 0 0 1-2-2V4a2 2 0 0 1 2-2h9a2 2 0 0 1 2 2v1" />
</svg>
</button>
</div>
</div>
Expand Down
5 changes: 4 additions & 1 deletion public/css/home.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2040,5 +2040,8 @@
}
}


*:focus-visible {
outline: 2px solid #a855f7 !important;
outline-offset: 2px;
}

14 changes: 14 additions & 0 deletions public/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,3 +842,17 @@ input, textarea, select {
transition:.2s;
}

/* ─── Focus Indicator for Keyboard Navigation ─── */
*:focus-visible {
outline: 2px solid #a855f7;
outline-offset: 2px;
}

button:focus-visible,
a:focus-visible,
input:focus-visible,
textarea:focus-visible,
select:focus-visible {
outline: 2px solid #a855f7;
outline-offset: 2px;
}
14 changes: 9 additions & 5 deletions public/js/admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,9 @@
return;
}

list.innerHTML = categories.map(cat => `
list.innerHTML = categories
.map(
(cat) => `
<div class="category-item" data-id="${cat.id}">
<div class="category-drag-handle">
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2">
Expand All @@ -258,28 +260,30 @@
</svg>
</div>
<div class="category-icon" style="background: ${cat.color}20; color: ${cat.color}">
${cat.icon || '📁'}
${cat.icon || "📁"}
</div>
<div class="category-info">
<div class="category-name">${escapeHtml(cat.name)}</div>
<div class="category-count">${cat.link_count || 0} links</div>
</div>
<div class="category-actions">
<button class="btn btn-icon btn-secondary" data-action="edit" data-id="${cat.id}" title="Edit">
<button class="btn btn-icon btn-secondary" data-action="edit" data-id="${cat.id}" title="Edit" aria-label="Edit category">
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2">
<path d="M11 4H4a2 2 0 0 0-2 2v14a2 2 0 0 0 2 2h14a2 2 0 0 0 2-2v-7"/>
<path d="M18.5 2.5a2.121 2.121 0 0 1 3 3L12 15l-4 1 1-4 9.5-9.5z"/>
</svg>
</button>
<button class="btn btn-icon btn-danger" data-action="delete" data-id="${cat.id}" title="Delete">
<button class="btn btn-icon btn-danger" data-action="delete" data-id="${cat.id}" title="Delete" aria-label="Delete category">
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2">
<polyline points="3 6 5 6 21 6"/>
<path d="M19 6v14a2 2 0 0 1-2 2H7a2 2 0 0 1-2-2V6m3 0V4a2 2 0 0 1 2-2h4a2 2 0 0 1 2 2v2"/>
</svg>
</button>
</div>
</div>
`).join('');
`,
)
.join("");

// Add event listeners using event delegation
list.querySelectorAll('[data-action="edit"]').forEach(btn => {
Expand Down
1 change: 1 addition & 0 deletions public/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@
btn.rel = 'noopener noreferrer';
btn.className = 'social-icon-btn';
btn.title = platform.charAt(0).toUpperCase() + platform.slice(1);
btn.setAttribute("aria-label", `Visit our ${platform}`);
btn.innerHTML = SOCIAL_ICONS[platform];
socialsRow.appendChild(btn);
});
Expand Down