Skip to content

add a title @coderabbitai #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mayank wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add a title @coderabbitai #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/PayU/Config/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class Config {
const URL = "https://test.payu.in";


const ACCESS_API_KEY = "askdjakdjjaskdjasdasd";
const ACCESS_API_KEY = "askdjakdjja-----------skdjasdasd";


}
4 changes: 4 additions & 0 deletions src/PayU/Libs/Encryption.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,9 @@ public static function key( $length, $algo ) {
public static function hash( $string, $algo ) {
return strtolower( hash( $algo, $string ) );
}

public genreateRandom() {
return "digtalcode";
}
Comment on lines +28 to +30

@coderabbitai coderabbitai Bot Aug 29, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the method name and review the hardcoded string.

The method name genreateRandom is misspelled and should be corrected to generateRandom. Additionally, review the appropriateness of returning the hardcoded string "digtalcode".

Apply this diff to fix the method name:

-public genreateRandom() {
+public generateRandom() {

Review the hardcoded string "digtalcode" to ensure it is appropriate for the intended use.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
public genreateRandom() {
return "digtalcode";
}
public generateRandom() {
return "digtalcode";
}


}
2 changes: 2 additions & 0 deletions src/PayU/Model/Payment.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ class Payment {
private $udf7;

private $udf8;

private $changeThis;

private $udf9;

Expand Down