FTP: support ListDirectoryWithTime, use mtime for log dates#14495
Merged
Conversation
Try the new kCmdListDirectoryWithTime (opcode 16) listing and fall back to ListDirectory on UnknownCommand, caching support per vehicle. Onboard log download now prefers the vehicle-reported modification time.
Contributor
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 2 passed, 46 failed, 7 skipped. Test Resultslinux-coverage: 90 passed, 0 skipped Code CoverageCoverage: 62.7% No baseline available for comparison Artifact Sizes
Updated: 2026-06-08 03:03:32 UTC • Commit: 37fffa3 • Triggered by: Android |
Contributor
Author
|
@HTRamsey any objections? |
Member
|
Nope. Go ahead and convert the whole FTP implementation to QGCStateMachine while you're at it lol |
Contributor
Author
|
Haha, let's leave that for another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Try the new kCmdListDirectoryWithTime (opcode 16) listing and fall back to ListDirectory on UnknownCommand, caching support per vehicle.
Onboard log download now prefers the vehicle-reported modification time.
Type of Change
Testing
Platforms Tested
Flight Stacks Tested
Screenshots
Checklist
Related Issues
Follow up to #14290.
Implementing mavlink/mavlink-devguide#701.
Tested against:
ArduPilot/ardupilot#33290
And:
PX4/PX4-Autopilot#27542
By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).