Skip to content

Jump commands - can only be used in missions#1871

Open
hamishwillee wants to merge 1 commit into
masterfrom
hamishwillee-patch-8
Open

Jump commands - can only be used in missions#1871
hamishwillee wants to merge 1 commit into
masterfrom
hamishwillee-patch-8

Conversation

@hamishwillee

@hamishwillee hamishwillee commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

This just specifies that jump commands can only be used in missions using the missionOnly attribute. Note that there was a lot of other churn when this was posted, but that has squashed down to just this simple change.

@peterbarker Are you OK with this? It is the first application of the attribute, that has been in the XSD for some years.
Note, there is also ArduPilot/pymavlink#1223 that is needed to fix that up :-)

Comment thread message_definitions/v1.0/common.xml Outdated
Comment thread message_definitions/v1.0/common.xml
@hamishwillee hamishwillee marked this pull request as draft August 4, 2022 01:20
@hamishwillee

Copy link
Copy Markdown
Contributor Author

@julianoes @auturgy As discussed in dev call. Made it a draft as there are "questions to be asked".

@hamishwillee hamishwillee force-pushed the hamishwillee-patch-8 branch 2 times, most recently from 3326fae to 4e679db Compare September 14, 2022 05:20
Comment thread message_definitions/v1.0/common.xml
@hamishwillee hamishwillee marked this pull request as ready for review September 14, 2022 05:23
@hamishwillee hamishwillee changed the title Jump commands - specify minimum repeats as 1 Jump commands - can only be used in missions Sep 14, 2022
Comment thread message_definitions/v1.0/common.xml
Comment thread message_definitions/v1.0/common.xml Outdated
Comment thread message_definitions/v1.0/common.xml Outdated
Comment thread message_definitions/v1.0/common.xml Outdated
Comment thread message_definitions/v1.0/common.xml Outdated
Comment thread message_definitions/v1.0/common.xml Outdated
Comment thread message_definitions/v1.0/common.xml Outdated
@hamishwillee hamishwillee force-pushed the hamishwillee-patch-8 branch from f8c42be to 2a9f69f Compare June 25, 2026 05:29
@hamishwillee hamishwillee requested a review from peterbarker June 25, 2026 05:30

@peterbarker peterbarker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants