keep external imports after connection loss - #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
https://kmv.ru/for-home.htmlthat cancels the initiating request while a resource is downloading and verifies that both the page and its revision are storedRoot cause
The import pipeline and final database writes used
r.Context(). When the browser, proxy, or progress connection disappeared during a long import, that context was cancelled. Database writes then failed, but their errors were discarded, allowing the UI to finish and redirect to a page that had never been created.Impact
External page and whole-site imports now continue to completion after an incidental client/proxy connection loss. A successful response is sent only after the imported page and revision have actually been stored.
Validation
GOCACHE=/private/tmp/sitebrush-gocache go test . -run '^TestGrab(StoresPageAndRevisionAfterRequestConnectionIsLost|UsesRequestPathWhenPostedPathIsMissing)$' -count=1git diff --checkThe full
go test ./...run still reports unrelated existing failures involving live DNS/mail relay behavior, platform-dependent disk usage, and stale static-asset expectations.