update netchan after logger fix - #43
Merged
Merged
Conversation
matveynator
marked this pull request as ready for review
July 30, 2026 20:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
github.com/matveynator/netchanfrom the temporary PR commit to merge commitf9eaab1now present onnetchan/maingo.sumWhy
SiteBrush PR #42 was merged while its dependency still pointed at the tested commit from NetChan PR #4. NetChan PR #4 is now merged, so SiteBrush should track the canonical commit from the dependency's main branch.
The merge commit has the same source tree as the previously tested PR commit; this is a dependency-history normalization only.
Checks
GOCACHE=/private/tmp/sitebrush-gocache go test . -run TestVersionCommandPrintsOnlyVersionWithoutCreatingStorage -count=1GOCACHE=/private/tmp/sitebrush-gocache go test ./pkg/...git diff --check