Fix all open CodeQL code scanning alerts - #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR addresses all 41 CodeQL alerts currently open on
main:Password protection
Existing page-protection rules stored with the legacy
sha256:digest intentionally stop authenticating. An administrator must set a new password for those protected paths after deployment. Keeping a legacy verifier would preserve the vulnerable password mechanism that these alerts identify.Logging
Allocation safety
Root causes
The page-protection subsystem used a fast digest for passwords and an unkeyed digest for session binding. Diagnostic logging accepted externally influenced strings and complete SQL summaries without a mandatory sanitization boundary. One slice-capacity calculation relied on practical memory limits instead of proving that integer addition could not overflow.
Validation
GOCACHE=/private/tmp/sitebrush-gocache go test -count=1 ./pkg/... ./scripts/...gosec -include=G703,G704 ./...— 0 issuesgit diff --checkThe GitHub CodeQL workflow is the final validation for the exact
security-extendedquery suite used to create these alerts.