Add encoder option to write infinity and NaN as null#18
Merged
Conversation
mattt
changed the title
There was a problem hiding this comment.
Pull request overview
This pull request adds support for handling infinity and NaN values during JSON serialization by introducing two new writing options. The implementation leverages existing flags in the underlying yyjson C library and extends both the YYJSONSerialization and YYJSONEncoder APIs to support these options.
Changes:
- Added
.allowInfAndNaNoption to write infinity/NaN as literals (non-standard JSON) - Added
.infAndNaNAsNulloption to write infinity/NaN as null, with precedence over.allowInfAndNaN - Updated validation logic to conditionally allow non-finite numbers based on options
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/YYJSONTests/SerializationTests.swift | Added comprehensive tests for YYJSONSerialization with new options, including precedence testing |
| Tests/YYJSONTests/ConfigurationTests.swift | Added tests for YYJSONEncoder with new options, covering both infinity and NaN cases |
| Sources/YYJSON/Serialization.swift | Implemented option handling in WritingOptions, validation logic, and value conversion |
| Sources/YYJSON/Encoder.swift | Added numberValue helper and threaded writeOptions through all encoding containers |
| Sources/YYJSON/Configuration.swift | Updated YYJSONWriteOptions documentation with improved clarity and precedence notes |
| README.md | Updated documentation in two sections to document the new non-standard options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.