Skip to content

Same as #232 but squashed (Implement MSC4144)#244

Open
SwirlyStone5877 wants to merge 1 commit into
matterbridge-org:masterfrom
SwirlyStone5877:msc4144-squashed
Open

Same as #232 but squashed (Implement MSC4144)#244
SwirlyStone5877 wants to merge 1 commit into
matterbridge-org:masterfrom
SwirlyStone5877:msc4144-squashed

Conversation

@SwirlyStone5877

Copy link
Copy Markdown

had to make a new mr because git squashing is a mess

relates to #208

@SwirlyStone5877

Copy link
Copy Markdown
Author

why does github keep saying this branch can't be rebased... grah

@SwirlyStone5877

Copy link
Copy Markdown
Author

i should explain the rationale behind the new ID: msg.UserID + "/" + username.plain,
matterbridge has ExtractNicks as a feature. unfortunately this doesn't change the user id of the recieved message, which could make some supporting clients think that two people are the same person, which is not true in reality
this did happen when i tried setting up a mcgalaxy-irc bridge and tried bridging that to matrix with this feature
see this screenshot:
image
i don't have a screenshot of the irc side on me, but the first message in the ss was sent by the system on the mc bridge while the rest were sent by me; twice on the mc bridge, once on my own irc account, then thrice more on the mc bridge

see matterbridge-org#232 and SwirlyStone5877/matterbridge-but-this-time-i-wont-screw-everything-up:msc4144 for actual changes made
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant