Implement MSC4144

[SwirlyStone5877]

Implements matrix-org/matrix-spec-proposals#4144

fixes #208 (ok not "fixes" but that's the keyword github wants for that)

[poVoq]

Should probably mention in the documentation that this MSC is as of now a draft only and not yet official?

It should probably also mention that on most clients you will only see the fallback.

Speaking of the fallback, why does it need to be different from the regular configurable message prefix of non-puppeteered/user-spoofing bridges? Can't it just reuse that, so that it looks the same as without this feature enabled on non-supporting Matrix clients?

[SwirlyStone5877]

unfortunately the spec requires that the fallback be Nick: msg in plaintext or <strong mx-data-i-forget-the-tag>Nick: </strong>msg in formatted

i will do those other doc fixes in a bit, unfortunately in a few hours i leave for vacation and wont be able to fox anything else in this pr

also dont merge this yet, ive already found an issue...

[poVoq]

Well, the specs might only talk about a nick, but the bridge could substitute the nick for the full string that is generated by the matterbridge config (default nick + network etc.). Without this it would be trivial to impersonate a user in a multi-bridge scenario.

[SwirlyStone5877]

oh yeah i fixed the issue i mentioned before
unfortunately doc fixes are beyond me

[SwirlyStone5877]

Well, the specs might only talk about a nick, but the bridge could substitute the nick for the full string that is generated by the matterbridge config (default nick + network etc.). Without this it would be trivial to impersonate a user in a multi-bridge scenario.

i for one already use {LABEL} in my RemoteNickFormat to get around this
this is also an issue even without PMP

[poVoq]

Well, if this PR uses the full RemoteNickFormat for both the nick and the fallback nick then I see no issue.

[SwirlyStone5877]

fantastic
also, i do have just enough time for those doc fixes, though they may be a bit rough around the edges since i have to do them from a phone

[SwirlyStone5877]

well i've gotten ahold of a computer i can install git on... im gonna go ahead and squash these commits

[SwirlyStone5877]

oh dear, with all of the new commits i'd have to completely mangle the history...

[SwirlyStone5877]

yep, can't squash these without a new branch and therefore a new pr. sorry

[SwirlyStone5877]

fantastic! my "issue fix" did nothing

[SwirlyStone5877]

ah... i see the issue... i missed sendNormalMessage(Plaintext|HTML)...
also id say this all in xmpp but my preferred client of choice does not have a windows package...

[SwirlyStone5877]

removed a bunch of spammy comments from me :)

[SwirlyStone5877]

hrm... no jobs running?

[SwirlyStone5877]

oh my god did we do it

[SwirlyStone5877]

OH MY GOD WE DID IT
@natalie0x42 THANK YOU

[SwirlyStone5877]

unfortunately i have yet to test this code...

[SwirlyStone5877]

why are message edits screwed up again???????

[SwirlyStone5877]

oh... i never put the PMP stuff in the new content...

[SwirlyStone5877]

fantastic, i fixed it

[SwirlyStone5877]

i think im gonna leave this for a week before deciding that its cool to merge
so far within just a few days ive found issues with very basic things and id like to let this simmer for a bit

[SwirlyStone5877]

im gonna leave a small note here
when a week has passed im gonna do a new MR on a new branch for the sake of squashing all of those commits

i would do this on the current branch but last time it was a mess where i committed someone else's work...

[SwirlyStone5877]

well it's a bit late, but...