rocketchat: do not try to impersonate user if not required#229
Open
Kioob wants to merge 1 commit into
Open
Conversation
…true, this should partially fix matterbridge-org#153 Sending Alias and Avatar unconditionally causes a "Match failed" 400 error on RocketChat servers where the bot role does not have the message-impersonate permission. Only send these fields when PrefixMessagesWithNick is false. Fixes: matterbridge-org#153 Co-authored-by: Claude <claude@anthropic.com>
Collaborator
|
Can you please also add a changlog entry and any additional documentation required? Otherwise looks like a good change, but I have no way to test this. |
Collaborator
|
Hello. Do you still want this merged? Please see the above mentioned requirements for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rocketchat: do NOT try to impersonate user if PrefixMessagesWithNick=true, this should partially fix #153
Sending Alias and Avatar unconditionally causes a "Match failed" 400 error
on RocketChat servers where the bot role does not have the message-impersonate
permission. Only send these fields when PrefixMessagesWithNick is false.
Fixes #153
Ref: #153