fix: whatsmeow conversion script added to allow the latest version to work with go 1.24#224
Open
natalie0x42 wants to merge 2 commits into
Open
fix: whatsmeow conversion script added to allow the latest version to work with go 1.24#224natalie0x42 wants to merge 2 commits into
natalie0x42 wants to merge 2 commits into
Conversation
… work with go 1.24
Author
|
Thanks to (Hunv) for verifying that this works as expected for bridging to WhatsApp, tested on Fedora and Debian. The script is likely to fail on BSD's and MacOS since the I hope this helps with the release goals! |
Collaborator
|
Our CI currently also builds for MacOS and Windows, but I doubt either seems much actual use outside basic testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the concern about WhatsApp bridges currently being broken (#220) while also needing to preserve the ability to distribute a release for systems still using go version 1.24 (#222) I figure we can possibly get away with doing both.
This script's output builds just fine and connects to other bridges as normal, but I haven't had a chance to test it on WhatsApp yet. Hence, this PR is still in a draft state. If someone wants to give it a try and report back, that would be much appreciated.