Discord proxy#113
Conversation
|
Ready for review/testing @poVoq @Wohlstand |
9d392cc to
8ccaa81
Compare
| helper.HandleDownloadData(b.Log, &rmsg, name, caption, "", data, b.General) | ||
| // TODO: does the discord API have a unique ID for the file? | ||
| // in the meantime, let's reuse the filename | ||
| err = b.AddAttachmentFromURL(&rmsg, attach.Filename, attach.Filename, caption, attach.URL) |
There was a problem hiding this comment.
This should be processed in the background instead of blocking the main thread. This is wrong and we should merge #114 first and not edit file download at all here.
There was a problem hiding this comment.
On my end I already merged that: Wohlstand@3043425
|
I rebased this to the latest branch locally and tested on my end, it works for me. Additionally I applied the similar tweak to Telegram (just re-use of existing parameter and configuring bot instance with a custom client and proxied transomrt), otherwise the bridge was broken on my side, and I fixed it by adding the proxy here too. But, this tweak directly depends on this one. |
8ccaa81 to
745ed42
Compare
|
I just rebased myself. Let me know if this branch works for you @Wohlstand and we can merge it. Sorry in the rebase i lost your authorship information in the comment. If that's important to you, i can put it back somehow. Or you can open a new PR with your authorship :) |
745ed42 to
acd9860
Compare
|
@selfhoster1312, it's just matching the state at my production build, and it works. 👍 |
Great, could you maybe confirm if you shut down the proxy the success message is still printed? We should move it right after |
Of course it gets printed, because it's just a dumb print command, and it's supposed to print the success connection report after the connection function return or at the callback that confirms the connection was successfull. |
acd9860 to
5686b2c
Compare
This is the continuation of #109 and #48.
Apparently i couldn't push to @Wohlstand's branch on #109 so i had to open this PR here.