remove outdated controller test yaml overrides#4066
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a previously maintained override of a Project CHIP controller certification YAML test and updates the GitHub Actions workflow to stop copying patched controller test files into the connectedhomeip test suite, aligning the CI run with upstream test definitions.
Changes:
- Delete the patched controller certification test override
Test_TC_BINFO_2_1.yaml. - Remove the workflow copy step that injected
patched-controller-test-filesintoconnectedhomeip/src/app/tests/suites/. - Keep a targeted PICS tweak via
sedforSMOKECO.S.A000din the connectedhomeipci-pics-valuesfile.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| support/chip-testing/patched-controller-test-files/certification/Test_TC_BINFO_2_1.yaml | Removes an outdated local override of an upstream controller certification YAML test. |
| .github/workflows/chip-matterjs-tests.yml | Stops copying patched controller test files into connectedhomeip during CI; retains PICS value adjustment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.