Skip to content

Switch to llvm-cov for coverage reports#213

Merged
poljar merged 7 commits into
mainfrom
poljar/ci/switch-to-llvm-cov
Jul 1, 2025
Merged

Switch to llvm-cov for coverage reports#213
poljar merged 7 commits into
mainfrom
poljar/ci/switch-to-llvm-cov

Conversation

@poljar

@poljar poljar commented Jun 20, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@poljar poljar requested a review from dkasak as a code owner June 20, 2025 09:49
@codecov-commenter

codecov-commenter commented Jun 20, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (ee9993a) to head (d5a411c).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
- Coverage   90.25%   89.91%   -0.35%     
==========================================
  Files          34       34              
  Lines        1991     5383    +3392     
  Branches        0     5383    +5383     
==========================================
+ Hits         1797     4840    +3043     
- Misses        194      348     +154     
- Partials        0      195     +195     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread justfile
@poljar poljar requested review from richvdh and removed request for dkasak June 23, 2025 15:27
@richvdh

richvdh commented Jun 23, 2025

Copy link
Copy Markdown
Member

Could you give some background to this, for the archive? I gather we've been having problems with tarpaulin?

Comment thread justfile Outdated
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@poljar

poljar commented Jun 24, 2025

Copy link
Copy Markdown
Collaborator Author

Could you give some background to this, for the archive? I gather we've been having problems with tarpaulin?

Sure. On the SDK side of things we saw some intermittent problems with the coverage reporting on the CI.

For a while we patched over the problem by excluding some parts of the SDK from coverage reports: matrix-org/matrix-rust-sdk#5180.

It's unclear if the SEGFAULT is caused by the added instrumentation to gather coverage data or some upstream issue.

The issue has been reported upstream but as there is not resolution yet we had to move on.

The SDK has thus switched to llvm-cov for code coverage and it only feels natural to do the same for vodozemac.

The added benefit here is that llvm-cov seems to handle incremental compilation a bit better.

@poljar poljar requested a review from richvdh June 24, 2025 11:15
Comment thread .github/workflows/coverage.yml Outdated
Comment thread .github/workflows/coverage.yml Outdated
poljar and others added 2 commits July 1, 2025 14:59
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
This ensures that the version that was used in the CI doesn't change
without us noticing.
@poljar poljar requested a review from richvdh July 1, 2025 13:13

@richvdh richvdh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poljar poljar enabled auto-merge (rebase) July 1, 2025 14:16
@poljar poljar merged commit bceccc6 into main Jul 1, 2025
4 of 8 checks passed
@poljar poljar deleted the poljar/ci/switch-to-llvm-cov branch July 1, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants