Skip to content

Add support to export an Account to a libolm pickle#111

Merged
poljar merged 4 commits into
mainfrom
poljar/account-libolm-pickle-support
Aug 4, 2023
Merged

Add support to export an Account to a libolm pickle#111
poljar merged 4 commits into
mainfrom
poljar/account-libolm-pickle-support

Conversation

@poljar

@poljar poljar commented Aug 4, 2023

Copy link
Copy Markdown
Collaborator

Split out from #95, contains only the support to pickle Accounts.

This is mostly needed for dehydrated devices, and should make landing #95
easier.

@poljar poljar force-pushed the poljar/account-libolm-pickle-support branch from e6e6f6e to d87d472 Compare August 4, 2023 08:48
@poljar poljar requested a review from dkasak August 4, 2023 08:53

@dkasak dkasak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some concerns around zeroization but otherwise looks good. Also spelled out the security issue with pickle keys in more detail. When these are addressed, this turns into an approve.

Comment thread src/olm/account/mod.rs Outdated
Comment thread src/olm/account/mod.rs Outdated
Comment thread src/olm/account/mod.rs Outdated
Comment thread src/olm/account/mod.rs Outdated
Comment thread src/olm/account/mod.rs Outdated
@poljar poljar enabled auto-merge (squash) August 4, 2023 13:10
@poljar poljar merged commit e3b6585 into main Aug 4, 2023
@poljar poljar deleted the poljar/account-libolm-pickle-support branch August 4, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants