No need to configure the LoggingContextFilter#1410
Merged
MadLittleMods merged 1 commit intoSep 26, 2025
Merged
Conversation
This hasn't been necessary for 5 years since matrix-org/synapse#8051
4 tasks
reivilibre
approved these changes
Sep 26, 2025
MadLittleMods
deleted the
madlittlemods/no-need-to-configure-LoggingContextFilter
branch
Contributor
Author
|
Thanks for the review @reivilibre 🐩 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to configure the
LoggingContextFilterThis hasn't been necessary for 5 years since matrix-org/synapse#8051 because we automatically configure this for you within Synapse itself.
Spawning from seeing this fail after we tried to change the
LoggingContextFilterconstructor in element-hq/synapse#18868 (comment). Although this served as a decent canary of what people may have historically configured, I've now added the relevant context to that part of the code as part of element-hq/synapse#18868