Skip to content

Fix save ratio check#90

Open
Fizzadar wants to merge 1 commit into
matrix-org:mainfrom
Fizzadar:fix-ratio-check
Open

Fix save ratio check#90
Fizzadar wants to merge 1 commit into
matrix-org:mainfrom
Fizzadar:fix-ratio-check

Conversation

@Fizzadar

@Fizzadar Fizzadar commented Jun 2, 2022

Copy link
Copy Markdown

Currently the compressor will rewrite state even if the result consists
of the same number of rows which doesn't match the log statement.

Currently the compressor will rewrite state even if the result consists
of the same number of rows which doesn't match the log statement.
@Fizzadar Fizzadar requested a review from a team as a code owner June 2, 2022 17:09
@erikjohnston

erikjohnston commented Jun 6, 2022

Copy link
Copy Markdown
Member

The clippy lint will be fixed by #92 #91

The test failure is annoying, as it looks like the test cases that we're using ends up generating the same number of rows?

@clokep

clokep commented Jun 7, 2022

Copy link
Copy Markdown
Member

I think this is waiting on @Fizzadar, so I'm going to remove this from the review queue.

@clokep clokep removed the request for review from a team June 7, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants