Bump MSRV to 1.80.0 in Cargo.toml and the Dockerfile#171
Conversation
#170 is failing to build due to requiring at least Rust 1.80. Let's just bump to 1.95.0 to take advantage of the latest fixes/features.
| # We leverage Zig and cargo-zigbuild for providing a cross-compilation-capable C compiler and linker. | ||
|
|
||
| ARG RUSTC_VERSION=1.78.0 | ||
| ARG RUSTC_VERSION=1.95.0 |
There was a problem hiding this comment.
We probably also need to bump it in Cargo.toml
rust-synapse-compress-state/Cargo.toml
Line 34 in 65ee643
There was a problem hiding this comment.
Correct! But we should bump this to 1.80.0 (the minimum required rust version), rather than 1.95.0 (the most advanced Rust version that will be used in the docker image). Do you agree?
Done in 1e6aa86.
There was a problem hiding this comment.
For the sake of Ctrl + f updating, I'd rather them be the same whichever direction.
We tend to just pick the latest whenever we update
There was a problem hiding this comment.
In that case... I think we should keep it at 1.80.x for both. That will make it easier to include the compressor as a library in other applications should one choose to do so.
anoadragon453
changed the title
Cargo.toml and the Dockerfile
2 participants
#170 is failing to build docker images due to requiring at least Rust 1.80 for
openssl-sys@0.9.115.Let's just bump to 1.95.0 to take advantage of the latest fixes/features.We opted to bump only to the minimum version needed to support the new openssl version.