Set MSC4293 flag when autoredacting users

[turt2live]

MSC: matrix-org/matrix-spec-proposals#4293

[H-Shay]

lgtm

[Gnuxie]

There is a risk here if Mjolnir fails to redact events in the fallback. This can happen if there are more events in the timeline than the pagination limit, or if a call to /redact fails. Trying to workaround by using !mjolnir redact will no longer work in this room because Mjolnir will no longer receive unredacted events from /messages due to the behavior of MSC4293.

[turt2live]

Receiving redacted events might be fine though? The logic could probably inspect the reason if it wanted too.

[Gnuxie]

That's true, It could be fine, but only because mjolnir doesn't exclude the redacted events from being called with /redact again

mjolnir/src/utils.ts

Lines 102 to 121 in 41a0ca2

	await getMessagesByUserIn(client, userIdOrGlob, targetRoomId, limit, async (eventsToRedact) => {
	for (const targetEvent of eventsToRedact) {
	await managementRoom.logMessage(
	LogLevel.DEBUG,
	"utils#redactUserMessagesIn",
	`Redacting ${targetEvent["event_id"]} in ${targetRoomId}`,
	targetRoomId,
	);
	if (!noop) {
	await client.redactEvent(targetRoomId, targetEvent["event_id"]);
	} else {
	await managementRoom.logMessage(
	LogLevel.WARN,
	"utils#redactUserMessagesIn",
	`Tried to redact ${targetEvent["event_id"]} in ${targetRoomId} but Mjolnir is running in no-op mode`,
	targetRoomId,
	);
	}
	}
	});

[tulir]

Was reason intentionally omitted here?