Improve domain splitting for "Hosted by" header#371
Open
luelista wants to merge 1 commit into
Open
Conversation
Domoel
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a preferred web instance is set, an additional "Hosted by example.com" label is shown. This label is supposed to display only the main domain without subdomains, so if "element.example.com" is set, we show "Hosted by example.com". However, the logic doesn't do that at all (in only works by accident for domains where the subdomain is exactly one character longer than the TLD, matching the quite common
chat.something.orgorapp.something.iostructure).The proposed code is still somewhat flawed as it wouldn't work properly for e.g. a
chat.example.co.ukdomain (displayingHosted on co.uk), but at least it works for the currently trusted instances.