-
-
Notifications
You must be signed in to change notification settings - Fork 145
Clarify that clients must avoid producing ambiguous matrix.to URIs #2396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Clarify that clients must avoid producing ambiguous matrix.to URIs. Contributed by @HarHarLinks. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -887,20 +887,21 @@ https://matrix.to/#/<identifier>/<extra parameter>?<additional arguments> | |
|
|
||
| The identifier may be a room ID, room alias, or user ID. The | ||
| extra parameter is only used in the case of permalinks where an event ID | ||
| is referenced. The matrix.to URI, when referenced, must always start | ||
| is referenced. The matrix.to URI, when referenced, MUST always start | ||
| with `https://matrix.to/#/` followed by the identifier. | ||
|
|
||
| The `<additional arguments>` and the preceding question mark are | ||
| optional and only apply in certain circumstances, documented below. | ||
| OPTIONAL and only apply in certain circumstances, documented below. | ||
|
|
||
| Clients should not rely on matrix.to URIs falling back to a web server | ||
| if accessed and instead should perform some sort of action within the | ||
| Clients SHOULD NOT rely on matrix.to URIs falling back to a web server | ||
| if accessed and instead SHOULD perform some sort of action within the | ||
| client. For example, if the user were to click on a matrix.to URI for a | ||
| room alias, the client may open a view for the user to participate in | ||
| room alias, the client MAY open a view for the user to participate in | ||
| the room. | ||
|
|
||
| The components of the matrix.to URI (`<identifier>` and | ||
| `<extra parameter>`) MUST be percent-encoded as per RFC 3986. | ||
| Clients MUST NOT produce incorrectly encoded URIs to avoid ambiguous interpretation. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What point is this making other than making the previous statement harder to skim over? Assuming that "incorrectly encoded" means "not percent-encoded".
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. historically, major implementations have ignored this:
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "incorrectly encoded" means "not encoded according to spec" 🤷 |
||
|
|
||
| Examples of matrix.to URIs are: | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.