MSC4441: User Profile Annotations ("Profile Notes")#4441
MSC4441: User Profile Annotations ("Profile Notes")#4441thetayloredman wants to merge 7 commits into
Conversation
tulir
added
A-Encryption
There was a problem hiding this comment.
Implementation requirements:
- Client (creating annotations)
- Client (rendering annotations)
github-project-automation
Bot
moved this to Tracking for review
in Spec Core Team Workflow
turt2live
moved this from Tracking for review
to Ready for general review
in Spec Core Team Workflow
|
The author would like review of this MSC prior to implementation, especially around crypto. See https://matrix.to/#/!0KNSXYXB_2xtEUkQ9MGBRy5oNIOfAKoq2uIqPZCJbI8/$Zss0QZ3VKtAqDlOCj4oBD2U7EO3UWVSgQ5xX3DuXe0Y?via=element.io&via=matrix.org&via=codestorm.net |
|
This may also benefit from the attempts at solving RMW races in #4438. The addition of an ADK for encrypting account data could also potentially benefit that MSC and could potentially be factored out into a separate proposal? |
Room annotations could use a different implementation via room account data and are out of scope for this MSC. Via review.
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
Some early review as an individual on the SCT - other SCT members might have other opinions. Sorry it's taken so long to get feedback.
Overall: it's not clear to me why encryption is needed or why extensible events is used. The title and actual proposal appear to be different as well: this proposal adds a local notes field which isn't mentioned in the title at all.
|
|
||
| Many platforms, such as Discord, provide a capability for a user to leave personal "notes" on a user's profile. Matrix, | ||
| however, has no similar functionality that can be shared between different clients. This proposal builds User Profile | ||
| Annotations, a method for storing encrypted, private metadata on user profiles. |
There was a problem hiding this comment.
the introduction should explain why encryption is required for this feature
There was a problem hiding this comment.
9f4151c rephrased this introduction to clarify that encryption benefits users who may place sensitive information in these profile annotations, alongside rephrasing the notes field.
| The framework introduced within this MSC builds upon [Extensible Events][MSC1767] and provides room for future extension | ||
| into other forms of user context, such as contact labels or custom nickname overrides. The content stored within these | ||
| annotations is also encrypted using an account secret scoped specifically for account data. |
There was a problem hiding this comment.
We've reclassified account data to not be an event in Matrix. Extensible events are also meant to improve rendering ability, not to provide a fallback structure - using them for profiles feels wrong, especially if those profiles are in account data rather than room events.
|
@thetayloredman note that for this MSC to be eligible to enter FCP, it will need sign off as well. |
Signed-off-by: Logan Devine <logan@zirco.dev>
thetayloredman
changed the title
Signed-off-by: Logan Devine <logan@zirco.dev>
Signed-off-by: Logan Devine <logan@zirco.dev>
4 participants
Rendered
Implementations:
Dependencies:
Signed-off-by: Logan Devine logan@zirco.dev