X.509 signatures and verification#6727
Open
kaylendog wants to merge 13 commits into
Open
Conversation
312322a to
6efd9e6
Compare
Co-Authored-By: Richard van der Hoff <richard@matrix.org> Co-Authored-By: Andy Balaam <andy.balaam@matrix.org> Co-Authored-By: Hubert Chathi <hubertc@matrix.org> Signed-off-by: Skye Elliot <actuallyori@gmail.com>
Co-Authored-By: Richard van der Hoff <richard@matrix.org> Co-Authored-By: Andy Balaam <andy.balaam@matrix.org> Co-Authored-By: Hubert Chathi <hubertc@matrix.org> Signed-off-by: Skye Elliot <actuallyori@gmail.com>
Co-Authored-By: Richard van der Hoff <richard@matrix.org> Co-Authored-By: Andy Balaam <andy.balaam@matrix.org> Co-Authored-By: Hubert Chathi <hubertc@matrix.org> Signed-off-by: Skye Elliot <actuallyori@gmail.com>
af3a99e to
0acbdac
Compare
Co-Authored-By: Richard van der Hoff <richard@matrix.org> Co-Authored-By: Andy Balaam <andy.balaam@matrix.org> Co-Authored-By: Hubert Chathi <hubertc@matrix.org> Signed-off-by: Skye Elliot <actuallyori@gmail.com>
Co-Authored-By: Richard van der Hoff <richard@matrix.org> Co-Authored-By: Andy Balaam <andy.balaam@matrix.org> Co-Authored-By: Hubert Chathi <hubertc@matrix.org> Signed-off-by: Skye Elliot <actuallyori@gmail.com>
Co-Authored-By: Richard van der Hoff <richard@matrix.org> Co-Authored-By: Andy Balaam <andy.balaam@matrix.org> Co-Authored-By: Hubert Chathi <hubertc@matrix.org> Signed-off-by: Skye Elliot <actuallyori@gmail.com>
Co-Authored-By: Richard van der Hoff <richard@matrix.org> Co-Authored-By: Andy Balaam <andy.balaam@matrix.org> Co-Authored-By: Hubert Chathi <hubertc@matrix.org> Signed-off-by: Skye Elliot <actuallyori@gmail.com>
Co-Authored-By: Richard van der Hoff <richard@matrix.org> Co-Authored-By: Andy Balaam <andy.balaam@matrix.org> Co-Authored-By: Hubert Chathi <hubertc@matrix.org> Signed-off-by: Skye Elliot <actuallyori@gmail.com>
Co-Authored-By: Richard van der Hoff <richard@matrix.org> Co-Authored-By: Andy Balaam <andy.balaam@matrix.org> Co-Authored-By: Hubert Chathi <hubertc@matrix.org> Signed-off-by: Skye Elliot <actuallyori@gmail.com>
Co-Authored-By: Richard van der Hoff <richard@matrix.org> Co-Authored-By: Andy Balaam <andy.balaam@matrix.org> Co-Authored-By: Hubert Chathi <hubertc@matrix.org> Signed-off-by: Skye Elliot <actuallyori@gmail.com>
Co-Authored-By: Richard van der Hoff <richard@matrix.org> Co-Authored-By: Andy Balaam <andy.balaam@matrix.org> Co-Authored-By: Hubert Chathi <hubertc@matrix.org> Signed-off-by: Skye Elliot <actuallyori@gmail.com>
Co-Authored-By: Richard van der Hoff <richard@matrix.org> Co-Authored-By: Andy Balaam <andy.balaam@matrix.org> Co-Authored-By: Hubert Chathi <hubertc@matrix.org> Signed-off-by: Skye Elliot <actuallyori@gmail.com>
0acbdac to
6521e26
Compare
Co-Authored-By: Richard van der Hoff <richard@matrix.org> Co-Authored-By: Andy Balaam <andy.balaam@matrix.org> Co-Authored-By: Hubert Chathi <hubertc@matrix.org> Signed-off-by: Skye Elliot <actuallyori@gmail.com>
6521e26 to
99bc3da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements X.509 signatures and verification, and is a refactored/linear version of the changes in
andyrich/x509.This is a big PR, so I have compressed the original changes into several discrete commits, each of which should be independently reviewable:
X509Signaturestruct, and the two core traits,X509SignerandX509Verifier.rsavulnerabilityThe crate we use for constructing signature definitions,
rsa, has a vulnerability in its padding algorithm (see RustCrypto/RSA#626). However, this only affects RSA private key operations, which we don't perform at all. Thus, we should be able to safely ignore the attached CI failures.PR Checklist
Signed-off-by: