chore(xtask): add size-optimized apple-release profile#6714
Draft
stefanceriu wants to merge 2 commits into
Draft
chore(xtask): add size-optimized apple-release profile#6714stefanceriu wants to merge 2 commits into
stefanceriu wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6714 +/- ##
=======================================
Coverage 89.95% 89.95%
=======================================
Files 398 398
Lines 110906 110906
Branches 110906 110906
=======================================
+ Hits 99764 99768 +4
+ Misses 7379 7365 -14
- Partials 3763 3773 +10 ☔ View full report in Codecov by Harness. |
Distributed Apple framework built with release links ~33% more code than necessary. Add an apple-release profile using opt-level = "s", which measured ~33% smaller linked code with no behavior change.
b47f6f7 to
761911f
Compare
Member
|
Why not using the |
Member
|
I believe it's because Xcode strips the symbols for us when we archive the app, but not only that, if they're in the XCFramework then it will also include them in the .dSYM bundle for crash log symbolication. |
…lease to the Swift xtask.
pixlwave
reviewed
Jul 8, 2026
|
|
||
| # Profile for the distributed Apple framework. `opt-level = "s"` measured ~33% | ||
| # smaller linked code than `release`. | ||
| [profile.apple-release] |
Member
There was a problem hiding this comment.
Maybe we should call this swift-release given it will be used by the swift xtask?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distributed Apple framework built with release links ~33% more code than necessary. Add an apple-release profile using opt-level = "s", which measured ~33% smaller linked code with no behavior change.
This is to address "This [binary] exceeds the cellular network download size limit and may require your app to be downloaded over Wi-Fi. Users running iOS 13 or later can choose to use cellular data to download apps that exceed this limit." AppStore warnings.