feat(qr-code): Add continuation sender to WaitingForAuth#6711
Draft
hughns wants to merge 3 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6711 +/- ##
==========================================
- Coverage 89.94% 89.92% -0.02%
==========================================
Files 397 397
Lines 110751 110793 +42
Branches 110751 110793 +42
==========================================
+ Hits 99611 99636 +25
- Misses 7367 7382 +15
- Partials 3773 3775 +2 ☔ View full report in Codecov by Harness. |
Merging this PR will improve performance by 35.23%
Performance Changes
Tip Curious why this is faster? Comment Comparing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a continuation sender to the
WaitingForAuthenums so that applications which suspend or navigate away while the verification URI is open (e.g. on Android) can resume the process explicitly.This is based on @poljar's work in #6173
Signed-off-by: Hugh Nimmo-Smith hughns@element.io